rjgonzale/laravel-appstore-notifications
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disabled shared secret check and return 500 not 400 on error

Browse Source
This commit is contained in:
Rodrigo Gonzalez 2020-09-09 10:59:17 -03:00
parent 9ba9e064dd
commit bd3c0fb660
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/WebhooksController.php
View File

@ -14,9 +14,10 @@ class WebhooksController
public function __invoke(Request $request) public function __invoke(Request $request)
{ {
$jobConfigKey = NotificationType::{$request->input('notification_type')}(); $jobConfigKey = NotificationType::{$request->input('notification_type')}();
$this->determineValidRequest($request->input('password'));
$notificationId = AppleNotification::storeNotification($jobConfigKey, $request->input()); AppleNotification::storeNotification($jobConfigKey, $request->input());
//$this->determineValidRequest($request->input('password'));
$payload = NotificationPayload::createFromRequest($request); $payload = NotificationPayload::createFromRequest($request);

2
src/exceptions/WebhookFailed.php
View File

@ -8,7 +8,7 @@ class WebhookFailed extends Exception
{ {
public static function nonValidRequest() public static function nonValidRequest()
{ {
return new static("Your shared secret does not match password in Apple's request", 400); return new static("Your shared secret does not match password in Apple's request", 500);
} }
public static function jobClassDoesNotExist(string $jobClass) public static function jobClassDoesNotExist(string $jobClass)